On 05/12/17 16:32, Greg KH wrote:
On Tue, Dec 05, 2017 at 04:14:23PM +0000, Michael Drake wrote:This adds a new way of dumping descriptors, which splits the knowledge of how to interpret descriptor data from the actual dumping. This has two advantages: 1. It is easy to add support for new descriptors, since they are now simple definitions that resemble the tables in the USB specifications. 2. The code for dumping descriptors is common, so the output is easy to keep consistent. It is also consistent and thorough in its handling of insufficient descriptor data buffer, and junk data at the end of a descriptor. UAC1 and UAC2 are converted to use the new mechanism, initial support for UAC3 is added. Finally, support for the USB3 BOS Configuration Summary Descriptor is added. This was previously opened as a github pull request here: https://github.com/gregkh/usbutils/pull/61Overall this looks great, I only have a few minor formatting and other procedural issues with the patches. I'll respond to them individually as to what could be fixed up for a resend.
Thanks for your review! I'll submit a v2 when I know what to do about the ChangeLog. Cheers, -- Michael Drake http://www.codethink.co.uk/ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
