Re: [PATCH] USB: uas and storage: Add US_FL_BROKEN_FUA for another JMicron JMS567 ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 5 Dec 2017, David Kozub wrote:

> There is another JMS567-based USB3 UAS enclosure (152d:0578) that fails
> with the following error:
> 
> [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
> [sda] tag#0 Sense Key : Illegal Request [current]
> [sda] tag#0 Add. Sense: Invalid field in cdb
> 
> The issue occurs both with UAS (occasionally) and mass storage
> (immediately after mounting a FS on a disk in the enclosure).
> 
> Enabling US_FL_BROKEN_FUA quirk solves this issue.
> 
> This patch adds an UNUSUAL_DEV with US_FL_BROKEN_FUA for the enclosure
> for both UAS and mass storage.
> 
> Signed-off-by: David Kozub <zub@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/storage/unusual_devs.h | 7 +++++++
>  drivers/usb/storage/unusual_uas.h  | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 2968046e7c05..f72d045ee9ef 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2100,6 +2100,13 @@ UNUSUAL_DEV(  0x152d, 0x0567, 0x0114, 0x0116,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BROKEN_FUA ),
>  
> +/* Reported by David Kozub <zub@xxxxxxxxxxxxxxxxxx> */
> +UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
> +		"JMicron",
> +		"JMS567",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_BROKEN_FUA),
> +
>  /*
>   * Reported by Alexandre Oliva <oliva@xxxxxxxxxxxxxxxxx>
>   * JMicron responds to USN and several other SCSI ioctls with a
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index d520374a824e..e6127fb21c12 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -129,6 +129,13 @@ UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BROKEN_FUA | US_FL_NO_REPORT_OPCODES),
>  
> +/* Reported-by: David Kozub <zub@xxxxxxxxxxxxxxxxxx> */
> +UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
> +		"JMicron",
> +		"JMS567",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_BROKEN_FUA),
> +
>  /* Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx> */
>  UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
>  		"VIA",

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux