Re: [PATCH] usb/gadget: don't skip numbers 10-16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2 Apr 2009, Sebastian Andrzej Siewior wrote:

> Signed-off-by: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx>
> ---
> Cutting the 0x prefix would be also a way to go :)

NAK.  These numbers are used to create bcdDevice values, and those 
values must be BCD.  In other words, nybbles between 0xA and 0xF are 
forbidden.

Alan Stern

>  drivers/usb/gadget/gadget_chips.h |   24 ++++++++++++------------
>  1 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/usb/gadget/gadget_chips.h b/drivers/usb/gadget/gadget_chips.h
> index ec6d439..17870e2 100644
> --- a/drivers/usb/gadget/gadget_chips.h
> +++ b/drivers/usb/gadget/gadget_chips.h
> @@ -203,6 +203,18 @@ static inline int usb_gadget_controller_number(struct usb_gadget *gadget)
>  		return 0x08;
>  	else if (gadget_is_lh7a40x(gadget))
>  		return 0x09;
> +	else if (gadget_is_atmel_usba(gadget))
> +		return 0x0a;
> +	else if (gadget_is_fsl_usb2(gadget))
> +		return 0x0b;
> +	else if (gadget_is_amd5536udc(gadget))
> +		return 0x0c;
> +	else if (gadget_is_m66592(gadget))
> +		return 0x0d;
> +	else if (gadget_is_fsl_qe(gadget))
> +		return 0x0e;
> +	else if (gadget_is_ci13xxx(gadget))
> +		return 0x0f;
>  	else if (gadget_is_n9604(gadget))
>  		return 0x10;
>  	else if (gadget_is_pxa27x(gadget))
> @@ -219,18 +231,6 @@ static inline int usb_gadget_controller_number(struct usb_gadget *gadget)
>  		return 0x16;
>  	else if (gadget_is_mpc8272(gadget))
>  		return 0x17;
> -	else if (gadget_is_atmel_usba(gadget))
> -		return 0x18;
> -	else if (gadget_is_fsl_usb2(gadget))
> -		return 0x19;
> -	else if (gadget_is_amd5536udc(gadget))
> -		return 0x20;
> -	else if (gadget_is_m66592(gadget))
> -		return 0x21;
> -	else if (gadget_is_fsl_qe(gadget))
> -		return 0x22;
> -	else if (gadget_is_ci13xxx(gadget))
> -		return 0x23;
>  	return -ENOENT;
>  }
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux