On Wednesday 01 April 2009, Justin Waters wrote:
> The flexible array in the USBH platform data is not safe to copy. The
> compiler will not allocate any extra memory for the non-init platform
> data structure (in the *_devices.c files) since it isn't given any
> defaults at compile time. When the probe function attempts to address
> that array, it will actually attempt to access data in an adjacent
> structure.
>
> Since there are currently no (known) implementations of the at91 USBH
> IP with more than 2 vbus pins, I am capping the value at 2. If somebody
> tries to assign more, then the compiler will produce a warning.
>
> Signed-off-by: Justin Waters <justin.waters@xxxxxxxxxxx>
Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> ---
> arch/arm/mach-at91/include/mach/board.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-at91/include/mach/board.h b/arch/arm/mach-at91/include/mach/board.h
> index 793fe7b..e6afff8 100644
> --- a/arch/arm/mach-at91/include/mach/board.h
> +++ b/arch/arm/mach-at91/include/mach/board.h
> @@ -87,7 +87,7 @@ extern void __init at91_add_device_eth(struct at91_eth_data *data);
> /* USB Host */
> struct at91_usbh_data {
> u8 ports; /* number of ports on root hub */
> - u8 vbus_pin[]; /* port power-control pin */
> + u8 vbus_pin[2]; /* port power-control pin */
> };
> extern void __init at91_add_device_usbh(struct at91_usbh_data *data);
>
> --
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
