Re: [PATCH] typec: fusb302: Use dev_err during probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2017-11-23 23:12, Guenter Roeck wrote:
On 11/23/2017 01:41 PM, Mats Karrman wrote:
If probe fails, fusb302_debugfs_exit is called making it impossible
to view any logs so use normal dev_err for any error messages during
probe.

Signed-off-by: Mats Karrman <mats.dev.list@xxxxxxxxx>
---
  drivers/staging/typec/fusb302/fusb302.c | 21 +++++++++++----------
  1 file changed, 11 insertions(+), 10 deletions(-)


The driver is now out of staging.
OK, missed that.
Which is the best/proper tree to base it on, kernel/git/gregkh/usb.git?

diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
index fc6a3cf..a9903a2 100644
--- a/drivers/staging/typec/fusb302/fusb302.c
-- 8< --
-        fusb302_log(chip,
-                "cannot request IRQ for GPIO Int_N, ret=%d", ret);
+        dev_err(&client->dev,
+            "cannot request IRQ for GPIO Int_N, ret=%d", ret);

You can use the 'dev' variable in the probe function.
Will do.


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux