Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Abhijeet@xxxxxxxxxxxxxxx, Kumar@xxxxxxxxxxxxxxx writes:

these emails don't exist. Fix your email client.

> From: abhijeet kumar <abhijeet.kumar@xxxxxxxxx>

capitalize names

> Runtime resume USB device in order to ensure that PM framework
> knows that the we might be using the device in a short time and doesn't
> autosuspend the device while we updating it's interface.

this doesn't tell me about any problem. What, exactly, are you trying to
fix?

> Signed-off-by: abhijeet kumar <abhijeet.kumar@xxxxxxxxx>

capitalize names

> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 371a07d874a3..658603ed779e 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1305,6 +1305,9 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
>  	if (iface->unregistering)
>  		return -ENODEV;
>  
> +	/*Letting runtime PM now that we wish to use the device in a short time
> +	 *pm_runtime_get(&iface->dev);
> +	 */

why is it so that adding commented out code help? Did you *really* test
this at all?

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux