Re: [patch 2.6.29] usb: musb_host, fix ep0 fifo flushing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 27 March 2009, Sergei Shtylyov wrote:
> > ... except that setting those bits, at least in this case, was
> > taking priority over flushing the fifo, causing the "flush" to
> > return with a packet left in the fifo.  Kind of a "non-flush".
> 
>     Hm...

And another reason I wanted to keep EP0 changes apart from
ones for other endpoints.  This change, I could observe as
working correctly.
 

> > (You had asked about CamelCase?  TXPktRdy, vs TXPKTRDY as
> > used in the driver, is one example.)
> 
>     That's how the bit is called in the MUSB documentation. I didn't feel 
> obliged to avoid CamelCase in the comments -- where it's not even a real 
> CamelCase. You're clearly over-strict here. :-)

Being consistent... DMAReqEnable (DMAENAB) and DMAReqMode (DMAMODE)
didn't have such an obvious mapping.

CaMelCaSe isn't limited to caps on word starts.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux