David Brownell wrote:
The driver incorrectly cancels the mass-storage device CSW request (which leads to device reset) due to giving back URB at the head of endpoint's queue after sending each STALL handshake; stop doing that and start checking for the queue being non-empty before stalling an endpoint and disallowing stall in such case in musb_gadget_set_halt() like the other gadget drivers do.
Also, the semantics of mass storage stall are not the same as the USB ch9 semantics ... that's why the set_wedge() operation is now defined.
Could you take another whack at this, and include set_wedge()?
You mean implementing set_wedge()? I thinkl this should be in another patch.
I'll give this an eyeballing anyway, on the grounds that at least some parts of this are probably right already ... just, the mass storage support can't be exactly correct.
Why? Is set_wedge() required now?
- Dave
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
