Re: [PATCH] rndis_host: support Novatel Verizon USB730L — Linux USB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 30, 2017 at 11:38:34AM +0000, Gal Shalif wrote:

> The following was used to switch the Novatel USB730L from user mode
> (product ID 0x9030) to enterprise mode (product ID 0x9032):
> 
> 
> * Kernel patche: add Novatel USB730L enterprise mode serial interface
> 
>     $ git show 9bacb30
>     commit 9bacb3082a90fc39047721a0887d5414f5e7008d
>     Author: Gal Shalif <gals@xxx>
>     Date:   Thu Oct 19 17:18:48 2017 +0300
> 
>         USB: serial: option: add support for Novatel USB730L enterprise mode
> 
>           Add device ID for Novatel USB730L enterprise mode
>           See details at: https://www.verizonwireless.com/dam/support/pdf/verizon-usb730l-integration-guide.pdf
> 
>     diff --git drivers/usb/serial/option.c drivers/usb/serial/option.c
>     index 54bfef1..bf5f637 100644
>     --- drivers/usb/serial/option.c
>     +++ drivers/usb/serial/option.c
>     @@ -162,6 +162,7 @@ static void option_instat_callback(struct urb *urb);
>      #define NOVATELWIRELESS_PRODUCT_E362           0x9010
>      #define NOVATELWIRELESS_PRODUCT_E371           0x9011
>      #define NOVATELWIRELESS_PRODUCT_U620L          0x9022
>     +#define NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L 0x9032 /* Novtel USB730L enterprize mode (from https://www.verizonwireless.com/dam/support/pdf/verizon-usb730l-integration-guide.pdf) */
>      #define NOVATELWIRELESS_PRODUCT_G2             0xA010
>      #define NOVATELWIRELESS_PRODUCT_MC551          0xB001
> 
>     @@ -1120,6 +1121,7 @@ static const struct usb_device_id option_ids[] = {
>             { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E362, 0xff, 0xff, 0xff) },
>             { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E371, 0xff, 0xff, 0xff) },
>             { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_U620L, 0xff, 0x00, 0x00) },
>     +       { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L, 0xff, 0x00, 0x00) }, /* Novtel USB730L enterprize mode (from https://www.verizonwireless.com/dam/support/pdf/verizon-usb730l-integration-guide.pdf) */
> 
>             { USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01) },
>             { USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01A) },

So I assume you still need the above change? Please submit this as a
proper patch that can be applied (e.g. see
Documentation/process/submitting-patches.rst).

There's no need to include the link in the code, just put in the commit
message. And don't forget you Signed-off-by.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux