On Sat, Oct 28, 2017 at 10:46:09PM +0000, Douglas Fischer wrote: > > Add USB PID/VID for Sierra Wireless EM7355 LTE modem QDL firmware update mode Add a new line before your SoB and make sure to wrap you commit message at 72 cols or so. > Signed-off-by: Douglas Fischer <douglas.fischer@xxxxxxxxxxx> > --- > > --- linux/drivers/usb/serial/qcserial.c.orig 2017-10-27 04:39:17.000000000 -0400 > +++ linux/drivers/usb/serial/qcserial.c 2017-10-28 17:36:11.255472598 -0400 > @@ -149,6 +149,7 @@ static const struct usb_device_id id_tab > {DEVICE_SWI(0x1199, 0x68c0)}, /* Sierra Wireless MC7304/MC7354 */ > {DEVICE_SWI(0x1199, 0x901c)}, /* Sierra Wireless EM7700 */ > {DEVICE_SWI(0x1199, 0x901f)}, /* Sierra Wireless EM7355 */ > + {DEVICE_SWI(0x1199, 0x901e)}, /* Sierra Wireless EM7355 QDL */ Please keep the entries sorted by PID. > {DEVICE_SWI(0x1199, 0x9040)}, /* Sierra Wireless Modem */ > {DEVICE_SWI(0x1199, 0x9041)}, /* Sierra Wireless MC7305/MC7355 */ > {DEVICE_SWI(0x1199, 0x9051)}, /* Netgear AirCard 340U */ Also this patch is white-space damaged (tabs replaces by spaces). Please fix your mail setup verify it by sending the patch to yourself first and making sure you can apply it with git-am. I can also suggest taking a look at git-send-email. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html