Hi Kishon,
Please review this so that I can re-submit patch-set based on this approach.
On 10/9/2017 1:33 PM, Manu Gautam wrote:
> Hi Kishon
>
> On 10/5/2017 2:38 PM, Manu Gautam wrote:
>> Kishon,
>> What would you suggest here?
>> Should we add new calls e.g. phy_get/set_current_speed like::
>>
>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
>> index 78bb0d7..41d9ec2 100644
>> --- a/include/linux/phy/phy.h
>> +++ b/include/linux/phy/phy.h
>> @@ -29,6 +29,14 @@ enum phy_mode {
>> PHY_MODE_USB_OTG,
>> };
>>
>> +enum phy_speed {
>> + PHY_SPEED_INVALID,
>> + PHY_SPEED_USB_LS,
>> + PHY_SPEED_USB_FS_HS,
>> + PHY_SPEED_USB_SS,
>> +};
>> +
>> /**
>> * struct phy_ops - set of function pointers for performing phy operations
>> * @init: operation to be performed for initializing phy
>> @@ -45,6 +53,7 @@ struct phy_ops {
>> int (*power_on)(struct phy *phy);
>> int (*power_off)(struct phy *phy);
>> int (*set_mode)(struct phy *phy, enum phy_mode mode);
>> + int (*set_speed)(struct phy *phy, enum phy_speed speed);
>> int (*reset)(struct phy *phy);
>> struct module *owner;
>> };
>>
> @Kishon,
> Let me know if we can add set_speed to phy_ops. We need this for glue
> driver to notify PHY of current connection speed to enable appropriate
> wakeup interrupts.
>
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
