On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > identifiers to all files in drivers/usb/ based on a script and data from > > Thomas Gleixner, Philippe Ombredanne, and Kate Stewart. > > > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx> > > Cc: Philippe Ombredanne <pombredanne@xxxxxxxx> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > --- > > Unless someone really complains, I'm going to add this to my tree for > > 4.15-rc1. > > > > > > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > > index 9650b351c26c..cb8d902b801d 100644 > > --- a/drivers/usb/Makefile > > +++ b/drivers/usb/Makefile > > @@ -1,6 +1,7 @@ > > # > > # Makefile for the kernel USB device drivers. > > # > > +# SPDX-License-Identifier: GPL-2.0 > > The last discussion about this was to add the identifier as the first line > of the file or as the second in case of files with a shebang in the first > one. > > I think you missed the last version of the script. Attached. Ugh, that's ugly, creating stuff like this: --- a/drivers/usb/atm/speedtch.c +++ b/drivers/usb/atm/speedtch.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0+ /****************************************************************************** * speedtch.c - Alcatel SpeedTouch USB xDSL modem driver * diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c Are we really ok with the '//' comments? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
