Re: [PATCH 1/3] USB: serial: metro-usb: stop I/O after failed open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 12, 2017 at 11:34:52AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 12, 2017 at 10:54:21AM +0200, Johan Hovold wrote:
> > Make sure to kill the interrupt-in URB after a failed open request.
> > Apart from saving power (and avoiding stale input after a later
> > successful open), this also prevents a NULL-deref in the completion
> > handler if the port is manually unbound.
> > 
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > ---
> >  drivers/usb/serial/metro-usb.c | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Thanks for the review, all three now applied.

I guess this one should go to stable, so I added the following:

Fixes: 704577861d5e ("USB: serial: metro-usb: get data from device in Uni-Directional mode.")
Cc: stable <stable@xxxxxxxxxxxxxxx>     # 3.5

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux