On 9/26/2017 2:44 AM, Mathias Nyman wrote: > On 25.09.2017 19:09, David Laight wrote: >> From: Adam Wallis >>> Sent: 25 September 2017 13:26 >>> inc_deq() currently bails earlier for EVENT rings than the common return >>> point of the function, due to the fact that EVENT rings do not have >>> link TRBs. The unfortunate side effect of this is that the very useful >>> trace_xhci_inc_deq() function is not called/usable for EVENT ring >>> debug. >> >> Is it actually worth using different functions for the different >> ring types? >> From what I remember there are conditionals in a lot of the functions >> but they are fixed for most of the call sites. >> > > There's some restructuring and refactoring that could be done in xhci, > but that's not part of this patch. > > This will just enable better debugging. > > Applying this patch Sounds great, thanks! Will this be going in on 4.14 sometime shortly? I hadn't seen it in your tree and was curious since we are tracking internally. Thanks! > > Thanks > -Mathias -- Adam Wallis Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
