On 09/30/2017 07:18 PM, Ben Hutchings wrote:
> usbip_host_driver.h now depends on several additional headers, which
> need to be installed along with it.
>
> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver ...")
> Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with ...")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
> I don't know of any external users of libusbip, but if it is going to
> install headers to support such users it should do so properly.
Not sure how many. But for correctness, I think it is good to fix this.
>
> Ben.
>
> tools/usb/usbip/Makefile.am | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/usb/usbip/Makefile.am b/tools/usb/usbip/Makefile.am
> index 66f8bf038c9f..45eaa70a71e0 100644
> --- a/tools/usb/usbip/Makefile.am
> +++ b/tools/usb/usbip/Makefile.am
> @@ -1,6 +1,7 @@
> SUBDIRS := libsrc src
> includedir = @includedir@/usbip
> include_HEADERS := $(addprefix libsrc/, \
> - usbip_common.h vhci_driver.h usbip_host_driver.h)
> + usbip_common.h vhci_driver.h usbip_host_driver.h \
> + list.h sysfs_utils.h usbip_host_common.h)
>
> dist_man_MANS := $(addprefix doc/, usbip.8 usbipd.8)
>
Looks good to me.
Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
Thanks for catching this.
Attachment:
signature.asc
Description: OpenPGP digital signature
