Re: [PATCH resend 09/12] usb: typec: tcpm: only drives the connected cc line when attached

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Li,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.14-rc2 next-20170927]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Li-Jun/staging-typec-tcpci-move-out-of-staging/20170927-190852
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Li-Jun/staging-typec-tcpci-move-out-of-staging/20170927-190852 HEAD 9e1467d3603f3cee8f039d52010dfb8d33e2b29c builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/staging/typec/tcpci.c: In function 'tcpci_probe':
>> drivers/staging/typec/tcpci.c:574:21: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
     tcpci->tcpc.set_cc = tcpci_set_cc;
                        ^
   cc1: some warnings being treated as errors

vim +574 drivers/staging/typec/tcpci.c

74e656d6 Guenter Roeck 2017-04-27  553  
74e656d6 Guenter Roeck 2017-04-27  554  static int tcpci_probe(struct i2c_client *client,
74e656d6 Guenter Roeck 2017-04-27  555  		       const struct i2c_device_id *i2c_id)
74e656d6 Guenter Roeck 2017-04-27  556  {
74e656d6 Guenter Roeck 2017-04-27  557  	struct tcpci *tcpci;
74e656d6 Guenter Roeck 2017-04-27  558  	int err;
74e656d6 Guenter Roeck 2017-04-27  559  
74e656d6 Guenter Roeck 2017-04-27  560  	tcpci = devm_kzalloc(&client->dev, sizeof(*tcpci), GFP_KERNEL);
74e656d6 Guenter Roeck 2017-04-27  561  	if (!tcpci)
74e656d6 Guenter Roeck 2017-04-27  562  		return -ENOMEM;
74e656d6 Guenter Roeck 2017-04-27  563  
74e656d6 Guenter Roeck 2017-04-27  564  	tcpci->client = client;
74e656d6 Guenter Roeck 2017-04-27  565  	tcpci->dev = &client->dev;
74e656d6 Guenter Roeck 2017-04-27  566  	i2c_set_clientdata(client, tcpci);
74e656d6 Guenter Roeck 2017-04-27  567  	tcpci->regmap = devm_regmap_init_i2c(client, &tcpci_regmap_config);
74e656d6 Guenter Roeck 2017-04-27  568  	if (IS_ERR(tcpci->regmap))
74e656d6 Guenter Roeck 2017-04-27  569  		return PTR_ERR(tcpci->regmap);
74e656d6 Guenter Roeck 2017-04-27  570  
74e656d6 Guenter Roeck 2017-04-27  571  	tcpci->tcpc.init = tcpci_init;
74e656d6 Guenter Roeck 2017-04-27  572  	tcpci->tcpc.get_vbus = tcpci_get_vbus;
74e656d6 Guenter Roeck 2017-04-27  573  	tcpci->tcpc.set_vbus = tcpci_set_vbus;
74e656d6 Guenter Roeck 2017-04-27 @574  	tcpci->tcpc.set_cc = tcpci_set_cc;
74e656d6 Guenter Roeck 2017-04-27  575  	tcpci->tcpc.get_cc = tcpci_get_cc;
74e656d6 Guenter Roeck 2017-04-27  576  	tcpci->tcpc.set_polarity = tcpci_set_polarity;
74e656d6 Guenter Roeck 2017-04-27  577  	tcpci->tcpc.set_vconn = tcpci_set_vconn;
74e656d6 Guenter Roeck 2017-04-27  578  	tcpci->tcpc.start_drp_toggling = tcpci_start_drp_toggling;
74e656d6 Guenter Roeck 2017-04-27  579  
74e656d6 Guenter Roeck 2017-04-27  580  	tcpci->tcpc.set_pd_rx = tcpci_set_pd_rx;
74e656d6 Guenter Roeck 2017-04-27  581  	tcpci->tcpc.set_roles = tcpci_set_roles;
74e656d6 Guenter Roeck 2017-04-27  582  	tcpci->tcpc.pd_transmit = tcpci_pd_transmit;
74e656d6 Guenter Roeck 2017-04-27  583  
74e656d6 Guenter Roeck 2017-04-27  584  	err = tcpci_parse_config(tcpci);
74e656d6 Guenter Roeck 2017-04-27  585  	if (err < 0)
74e656d6 Guenter Roeck 2017-04-27  586  		return err;
74e656d6 Guenter Roeck 2017-04-27  587  
74e656d6 Guenter Roeck 2017-04-27  588  	/* Disable chip interrupts */
74e656d6 Guenter Roeck 2017-04-27  589  	tcpci_write16(tcpci, TCPC_ALERT_MASK, 0);
74e656d6 Guenter Roeck 2017-04-27  590  
d94372b5 Li Jun        2017-09-26  591  	tcpci->port = tcpm_register_port(tcpci->dev, &tcpci->tcpc);
d94372b5 Li Jun        2017-09-26  592  	if (IS_ERR(tcpci->port))
d94372b5 Li Jun        2017-09-26  593  		return PTR_ERR(tcpci->port);
d94372b5 Li Jun        2017-09-26  594  
d94372b5 Li Jun        2017-09-26  595  	return devm_request_threaded_irq(tcpci->dev, client->irq, NULL,
74e656d6 Guenter Roeck 2017-04-27  596  					tcpci_irq,
74e656d6 Guenter Roeck 2017-04-27  597  					IRQF_ONESHOT | IRQF_TRIGGER_LOW,
74e656d6 Guenter Roeck 2017-04-27  598  					dev_name(tcpci->dev), tcpci);
74e656d6 Guenter Roeck 2017-04-27  599  }
74e656d6 Guenter Roeck 2017-04-27  600  

:::::: The code at line 574 was first introduced by commit
:::::: 74e656d6b0551999194b5ab1e45ff8b1e82b898e staging: typec: Type-C Port Controller Interface driver (tcpci)

:::::: TO: Guenter Roeck <groeck@xxxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux