Thanks for the feedback. I'll review and resubmit. -----Original Message----- From: Johan Hovold [mailto:jhovold@xxxxxxxxx] On Behalf Of Johan Hovold Sent: Wednesday, September 20, 2017 2:47 AM To: Schoon, Michael <michael.schoon@xxxxxx> Cc: johan@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Subject: Re: [PATCH] staging: pl2303: adding TD620 Device ID On Wed, Sep 20, 2017 at 08:15:38AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 19, 2017 at 09:41:48PM +0000, Schoon, Michael wrote: > > Signed-off-by: Michael Schoon <michael.schoon@xxxxxx> > > No changelog at all? I know I can't take patches like that, hopefully > Johan has the same rule :) Indeed, I do. Please also fix up the Subject; this driver does not live in staging so that should be "USB: serial: pl2303:" instead. Also try to keep any new id-defines you add sorted by PID. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html