Re: [PATCH] usb: pci-quirks.c: Corrected timeout values used in handshake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01.09.2017 09:21, Felipe Balbi wrote:

Hi,

Jim Dickerson <jim.dickerson@xxxxxxx> writes:
Servers were emitting failed handoff messages but were not
waiting the full 1 second as designated in section 4.22.1 of
the eXtensible Host Controller Interface specifications. The
handshake was using wrong units so calls were made with milliseconds
not microseconds. Comments referenced 5 seconds not 1 second as
in specs.

The wrong units were also corrected in a second handshake call.

Signed-off-by: Jim Dickerson <jim.dickerson@xxxxxxx>
---
  drivers/usb/host/pci-quirks.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index c8f3864..abc9436 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -1068,9 +1068,9 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
  	if (val & XHCI_HC_BIOS_OWNED) {
  		writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);

-		/* Wait for 5 seconds with 10 microsecond polling interval */
+		/* Wait for 1 seconds with 10 microsecond polling interval */
                               ^^^^^^^
                               second


Applying,
I'll fix the typo myself, don't worry about it

Thanks
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux