hi Greg: 2017-08-16 23:46 GMT+08:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > On Wed, Aug 16, 2017 at 11:01:20AM +0800, pierre Kuo wrote: >> try to fix some codeing style issue, such as "space prohibited" and "not >> initialise statics". > > Only do one type of thing in a single patch please. And no, "fix all > coding style issues" is not a single thing. > > This needs to be multiple patches. so you mean a. patch1 for "space prohibited" b. patch2 for "not initalise statics" right? > > If you want to do coding style cleanups, please start out in > drivers/staging/ so you can get the process correct. Got it. I just found some part of usb driver may need coding style cleanups while tracing code flow and hope can do some feedback to this mailing list. So you mean we first run some typo check on drivers/staging/ and once patches accepted then we started for usb part? BTW, I found below link show people use checkpatch.pl to checking coding style. http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel is that ok if we use "./scripts/checkpatch.pl -f drivers/usb/host/ehci-xxx.c" and create different patches based on different coding style issue? (like above #a and #b shows?) appreciate your kind help, -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
