Re: [PATCH v5 1/8] usb: gadget: f_ecm/f_eem/f_rndis: Setup quirk_avoids_skb_reserve

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Dmitry Osipenko <digetx@xxxxxxxxx> writes:
> This quirk is required to make USB Ethernet gadget working with HW that
> can't cope with unaligned DMA. For some reason only f_ncm handles that
> quirk, let's handle it in the rest of the network models. All models have
> been tested with a ChipIdea UDC driver on NVIDIA Tegra20 SoC that require
> DMA to be aligned.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
>  drivers/usb/gadget/function/f_ecm.c   | 7 +++++++
>  drivers/usb/gadget/function/f_eem.c   | 5 +++++
>  drivers/usb/gadget/function/f_rndis.c | 4 ++++
>  3 files changed, 16 insertions(+)
>
> diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c
> index 4c488d15b6f6..1d198055fd74 100644
> --- a/drivers/usb/gadget/function/f_ecm.c
> +++ b/drivers/usb/gadget/function/f_ecm.c
> @@ -584,6 +584,13 @@ static int ecm_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
>  			 */
>  			ecm->port.is_zlp_ok =
>  				gadget_is_zlp_supported(cdev->gadget);
> +
> +			/* Setup DMA alignment workaround for UDC's that
> +			 * need it.
> +			 */
> +			ecm->port.no_skb_reserve =
> +				gadget_avoids_skb_reserve(cdev->gadget);

looks like the quirk should be moved to u_ether.c instead.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux