On 8/4/2017 1:21 PM, Felipe Balbi wrote:
>
> Hi,
>
> Sandeep Singh <ssingh1@xxxxxxx> writes:
>>>>> Sandeep Singh <Sandeep.Singh@xxxxxxx> writes:
>>>>>> @@ -260,11 +266,12 @@ int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev *pdev)
>>>>>> {
>>>>>> /* Make sure amd chipset type has already been initialized */
>>>>>> usb_amd_find_chipset_info();
>>>>>> - if (amd_chipset.sb_type.gen != AMD_CHIPSET_YANGTZE)
>>>>>> - return 0;
>>>>>> -
>>>>>> - dev_dbg(&pdev->dev, "QUIRK: Enable AMD remote wakeup fix\n");
>>>>>> - return 1;
>>>>>> + if (amd_chipset.sb_type.gen == AMD_CHIPSET_YANGTZE ||
>>>>>> + AMD_CHIPSET_TAISHAN) {
>>>>>
>>>>> Sure this is what you wanna do?
>>>>>
>>>>
>>>> Yes. Please..
>>>
>>> Are you sure this works the way you think it will?
>>>
>> Yes. Can you please help me to understand your concern.
>
> Try evaluating that expression in your head. When will it be true and
> when will it false?
>
Apologies.. that was a blunder from my side :( I will take care of this in the new version of the patch. Thank you for pointing it out. Lessons learnt.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
