On Thu, Aug 03, 2017 at 09:02:32AM -0700, Greg KH wrote:
> On Thu, Aug 03, 2017 at 02:00:37PM +0530, Sandeep Singh wrote:
> >
> > >>> Sandeep Singh <Sandeep.Singh@xxxxxxx> writes:
> > >>>> @@ -260,11 +266,12 @@ int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev *pdev)
> > >>>> {
> > >>>> /* Make sure amd chipset type has already been initialized */
> > >>>> usb_amd_find_chipset_info();
> > >>>> - if (amd_chipset.sb_type.gen != AMD_CHIPSET_YANGTZE)
> > >>>> - return 0;
> > >>>> -
> > >>>> - dev_dbg(&pdev->dev, "QUIRK: Enable AMD remote wakeup fix\n");
> > >>>> - return 1;
> > >>>> + if (amd_chipset.sb_type.gen == AMD_CHIPSET_YANGTZE ||
> > >>>> + AMD_CHIPSET_TAISHAN) {
> > >>>
> > >>> Sure this is what you wanna do?
> > >>>
> > >>
> > >> Yes. Please..
> > >
> > > Are you sure this works the way you think it will?
> > >
> > Yes. Can you please help me to understand your concern.
>
> Logical vs. bitwise OR.
Actually, no, it's not even that type of error, it's just flat out
wrong... And it's obvious you didn't test this very well :(
Please be more careful.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
