On 7/21/2017 10:39 PM, Stephen Boyd wrote: > On 07/21/2017 04:02 AM, Manu Gautam wrote: >> Driver currently notifies only USB3 PHY for mode change. >> Extend this to USB3 PHY so that driver based on the mode >> can release system resources - clocks, regulators etc. >> and can even turn off PHY during runtime suspend. >> >> Signed-off-by: Manu Gautam <mgautam@xxxxxxxxxxxxxx> > This patch is confusing because you say "notify for usb3 phy", but then > combine a change to remove the NULL pointer check on phy_set_mode() for > the usb2 phy. Please describe everything that's happening in a patch in > the commit text. Sure, will add a comment for that. It was done to align with other phy_ops usage in the driver. Also, these wrapper functions already have a NULL pointer check. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
