On 07/19/2017 06:17 AM, Greg Kroah-Hartman wrote:
> MODULE_VERSION is useless for in-kernel drivers, so just remove all
> usage of it in the USB usbip drivers. Along with this, the
> USBIP_VERSION macros was removed as is was also pointless, as well as
> printing out the driver version to the syslog at init time, which is not
> necessary at all.
>
> Cc: Valentina Manea <valentina.manea.m@xxxxxxxxx>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/usbip/stub_main.c | 2 --
> drivers/usb/usbip/usbip_common.c | 2 --
> drivers/usb/usbip/usbip_common.h | 2 --
> drivers/usb/usbip/vhci_hcd.c | 2 --
> 4 files changed, 8 deletions(-)
>
> diff --git a/drivers/usb/usbip/stub_main.c b/drivers/usb/usbip/stub_main.c
> index 660180a5d5c4..7170404e8979 100644
> --- a/drivers/usb/usbip/stub_main.c
> +++ b/drivers/usb/usbip/stub_main.c
> @@ -302,7 +302,6 @@ static int __init usbip_host_init(void)
> goto err_create_file;
> }
>
> - pr_info(DRIVER_DESC " v" USBIP_VERSION "\n");
> return ret;
>
> err_create_file:
> @@ -335,4 +334,3 @@ module_exit(usbip_host_exit);
> MODULE_AUTHOR(DRIVER_AUTHOR);
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
> -MODULE_VERSION(USBIP_VERSION);
> diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
> index cab2b71a80d0..2281f3562870 100644
> --- a/drivers/usb/usbip/usbip_common.c
> +++ b/drivers/usb/usbip/usbip_common.c
> @@ -763,7 +763,6 @@ static int __init usbip_core_init(void)
> {
> int ret;
>
> - pr_info(DRIVER_DESC " v" USBIP_VERSION "\n");
> ret = usbip_init_eh();
> if (ret)
> return ret;
> @@ -783,4 +782,3 @@ module_exit(usbip_core_exit);
> MODULE_AUTHOR(DRIVER_AUTHOR);
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
> -MODULE_VERSION(USBIP_VERSION);
> diff --git a/drivers/usb/usbip/usbip_common.h b/drivers/usb/usbip/usbip_common.h
> index f8573a52e41a..3050fc99a417 100644
> --- a/drivers/usb/usbip/usbip_common.h
> +++ b/drivers/usb/usbip/usbip_common.h
> @@ -34,8 +34,6 @@
> #include <linux/sched/task.h>
> #include <uapi/linux/usbip.h>
>
> -#define USBIP_VERSION "1.0.0"
> -
> #undef pr_fmt
>
> #ifdef DEBUG
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 2c4b2fd40406..c747623990da 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1516,7 +1516,6 @@ static int __init vhci_hcd_init(void)
> }
> }
>
> - pr_info(DRIVER_DESC " v" USBIP_VERSION "\n");
> return ret;
>
> err_add_hcd:
> @@ -1542,4 +1541,3 @@ module_exit(vhci_hcd_exit);
> MODULE_AUTHOR(DRIVER_AUTHOR);
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
> -MODULE_VERSION(USBIP_VERSION);
>
Looks good to me.
Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
