Re: [PATCH 1/4] usb: musb: add helper function musb_ep_xfertype_string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 18, 2017 at 07:33:07PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 07/18/2017 06:13 PM, Bin Liu wrote:
> 
> >Add helper function musb_ep_xfertype_string() to return the ep transfer
> >type string.
> >
> >Signed-off-by: Bin Liu <b-liu@xxxxxx>
> 
>    Doesn't this belong to USB core? What's MUSB specific about it?

This was my first thought, because many drivers do this conversion
without using a helper function. But everyone returns different spelling
of the string (for example, for the Control type, the return is any of
"Control", "CONTROL", "control", "ctrl", and "CTL"), I am not sure how
to unify it without breaking backward compatibility.

Regards,
-Bin.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux