Re: [PATCH 6/9] USB: misc: remove unneeded MODULE_VERSION() usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 19, 2017 at 02:30:20PM +0200, Richard Leitner wrote:
> On 07/19/2017 02:17 PM, Greg Kroah-Hartman wrote:
> > MODULE_VERSION is useless for in-kernel drivers, so just remove all
> > usage of it in the USB misc drivers.  Along with this, some
> > DRIVER_VERSION macros were removed as they are also pointless.
> 
> ...
> 
> > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> > index 91f66d68bcb7..135c91c434bf 100644
> > --- a/drivers/usb/misc/usb251xb.c
> > +++ b/drivers/usb/misc/usb251xb.c
> > @@ -114,7 +114,6 @@
> >  
> >  #define DRIVER_NAME	"usb251xb"
> >  #define DRIVER_DESC	"Microchip USB 2.0 Hi-Speed Hub Controller"
> > -#define DRIVER_VERSION	"1.0"
> >  
> >  struct usb251xb {
> >  	struct device *dev;
> 
> As I'm pretty new to kernel development I don't know if it's
> needed/wanted in this case, but if so please feel free to add
> 
> Acked-by: Richard Leitner <richard.leitner@xxxxxxxxxxx>

It's always needed/wanted to get this, thanks!

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux