Sorry about that. How's this:
Please add support for HP TD620 Linear Display device to the pl2303 module. The USB Device ID is 03f0:0956 for this 2x20 display.
--- drivers/usb/serial/pl2303.c.orig 2017-07-14 13:43:59.029860481 -0500
+++ drivers/usb/serial/pl2303.c 2017-07-14 13:16:27.928149225 -0500
@@ -92,6 +92,7 @@ static const struct usb_device_id id_tab
{ USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
+ { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
{ USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
{ USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },
--- drivers/usb/serial/pl2303.h.orig 2017-07-14 13:44:08.893761456 -0500
+++ drivers/usb/serial/pl2303.h 2017-07-14 13:15:07.016508374 -0500
@@ -125,6 +125,7 @@
#define HP_LCM220_PRODUCT_ID 0x3139
#define HP_LCM960_PRODUCT_ID 0x3239
#define HP_LD220_PRODUCT_ID 0x3524
+#define HP_TD620_PRODUCT_ID 0x0956
/* Cressi Edy (diving computer) PC interface */
#define CRESSI_VENDOR_ID 0x04b8
-----Original Message-----
From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
Sent: Monday, July 17, 2017 10:28 AM
To: Schoon, Michael <michael.schoon@xxxxxx>
Cc: linux-usb@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] Adding TD620 Device ID in PL2303
On Mon, Jul 17, 2017 at 03:19:10PM +0000, Schoon, Michael wrote:
> Please add support for HP TD620 Linear Display device to the pl2303 module. The USB Device ID is 03f0:0956 for this 2x20 display.
>
> Changes to be committed:
> modified: drivers/usb/serial/pl2303.c
> modified: drivers/usb/serial/pl2303.h
>
Intersting indentation :(
Also, what is this "Changes to be..." line for?
And finally, did you run this through scripts/checkpatch.pl?
> --- drivers/usb/serial/pl2303.c 2017-07-14 13:16:27.928149225
> -0500
> +++ drivers/usb/serial/pl2303.c.orig 2017-07-14
> 13:43:59.029860481 -0500
> @@ -92,7 +92,6 @@ static const struct usb_device_id id_tab
> { USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
> { USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
> { USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
> - { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
Well, now finally, your patch is backwards and whitespace damaged, making it impossible to apply :(
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
