Hi,
Pratyush Anand <panand@xxxxxxxxxx> writes:
> Hi Felipe,
>
> On Friday 09 June 2017 11:43 AM, Felipe Balbi wrote:
>> +static void notrace ftrace_write(struct trace_export *ftrace, const void *buf,
>> + unsigned int len)
>> +{
>> + struct usb_ftrace *trace = ftrace_to_trace(ftrace);
>> + struct usb_request *req = next_request(&trace->list);
>> +
>> + if (!req)
>> + return;
>> +
>> + if (!trace->in->enabled)
>> + return;
>> +
>> + req->buf = kmemdup(buf, len, GFP_ATOMIC);
>
> Probably we can avoid the copy of trace data.
not with current setup. I have no control over data's lifetime. If I
did, then this would be zero-copy.
> We can make write() call of "struct trace_export" as posted. Can have a
that would require further patching in trace core which is not part of
$subject. Also, if we turn this into asynchronous calls, we could run
out of trace buffer before the first chunk of data is transferred over
to the other side.
> write_complete() callback function implemented in struct trace_export,which
> can be called from your ftrace_complete().
well, you're welcome to propose a patch :-)
--
balbi
Attachment:
signature.asc
Description: PGP signature
