> -----Original Message----- > From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] > Sent: Monday, July 10, 2017 3:57 PM > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > Cc: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>; USB <linux- > usb@xxxxxxxxxxxxxxx>; mathias.nyman@xxxxxxxxx; David.Laight@xxxxxxxxxx; > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Felipe Balbi > <felipe.balbi@xxxxxxxxxxxxxxx>; brain_lee@xxxxxxxxxxxxxx; > Justin_CY_Chen@xxxxxxxxxxxxxx; Wang, Keith <Keith_Wang@xxxxxxxx>; > Yd_Tseng@xxxxxxxxxxxxxx; Lars_chang@xxxxxxxxxxxxxx; > arequipeno@xxxxxxxxx; jiahau@xxxxxxxxx > Subject: Re: [PATCH v5] xhci: Bad Ethernet performance plugged in ASM1042A host > > On Mon, Jul 10, 2017 at 11:38 PM, <Mario.Limonciello@xxxxxxxx> wrote: > >> -----Original Message----- > >> From: Jiahau Chang [mailto:jiahau@xxxxxxxxx] > >> Sent: Thursday, July 6, 2017 8:58 PM > >> To: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > >> Cc: linux-usb@xxxxxxxxxxxxxxx; mathias.nyman@xxxxxxxxx; > >> David.Laight@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > >> felipe.balbi@xxxxxxxxxxxxxxx; brain_lee@xxxxxxxxxxxxxx; Limonciello, Mario > >> <Mario_Limonciello@xxxxxxxx>; Justin_CY_Chen@xxxxxxxxxxxxxx; Wang, > Keith > >> <Keith_Wang@xxxxxxxx>; Yd_Tseng@xxxxxxxxxxxxxx; Jiahau Chang > >> <Lars_chang@xxxxxxxxxxxxxx>; Ian Pilcher <arequipeno@xxxxxxxxx> > >> Subject: Re: [PATCH v5] xhci: Bad Ethernet performance plugged in ASM1042A > host > >> > >> 2017-06-28 21:42 GMT+08:00 Mathias Nyman > <mathias.nyman@xxxxxxxxxxxxxxx>: > >> > On 22.06.2017 07:49, Jiahau Chang wrote: > >> >> > >> >> When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad > >> >> performance was manifesting in Web browser use (like download > >> >> large file such as ISO image). It is known limitation of > >> >> ASM1042A that is not compatible with driver scheduling, > >> >> As a workaround we can modify flow control handling of ASM1042A. > >> >> The register we modify is changes the behavior > >> >> > >> >> Signed-off-by: Jiahau Chang <Lars_chang@xxxxxxxxxxxxxx> > >> >> Signed-off-by: Ian Pilcher <arequipeno@xxxxxxxxx> > >> >> --- > >> > > >> > > >> > Thanks, looks good, but checkpatch complains about: > >> > > >> >> + usleep_range(50, 50); > >> > > >> > > >> > having same min and max value. > >> > Does usleep_range(40,60) work for you? or some other range? > >> > > >> It works to use usleep_range(40,60); > >> Thanks for help us to upstream the patch. > >> > >> > I can change that myself, no need to resend. > >> > > > > > Matthias, > > > > Can you still get this in for 4.13? > > He is on vacation for few weeks. > > Perhaps in rcX. > > Thanks for the heads up, I wasn't aware since I didn't get back any OOO or anything like that. I hope this can make it into one of the rc's indeed then when he returns. Thanks ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
