Re: [PATCH] [RFC PATCH] Set NTB format again after altsetting switch for Huawei devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 7 Jul 2017, Bjørn Mork wrote:

Date: Fri, 7 Jul 2017 16:59:09
From: Bjørn Mork <bjorn@xxxxxxx>
To: Enrico Mioso <mrkiko.rs@xxxxxxxxx>
Cc: Christian Panton <christian@xxxxxxxxxx>, linux-usb@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] [RFC PATCH] Set NTB format again after altsetting switch
    for Huawei devices

Enrico Mioso <mrkiko.rs@xxxxxxxxx> writes:

Some firmwares in Huawei E3372H devices have been observed to switch back
to NTB 32-bit format after altsetting switch.
This patch implement a driver flag to check for the device settings and
set NTB format to 16-bit again if needed.
The flag has been activated for devices controlled by the huawei_cdc_ncm
driver.
I am not in a confortable position to test this code, so it may containg serious defects.
Let me know.


This looks good to me if it solves the problem for Christian.  Note that
you will have to resend it to netdev to have it applied, but I guess you
know that :-)
I didn't remember I should say. thank you very much Bjorn. If it wasn't for you, I wouldn't have started this. Thanks.

Feel free to add

Reviewed-by: Bjørn Mork <bjorn@xxxxxxx>

when you do so, if you want.

For sure, it's a Honor for me.
Sorry for the disturbance - but can I ask you to revise my V2 patch? I sent it.
Christian, please test V2 too.

I will send it to netdev for merning once you Bjorn, and you Christian, are happy and the patch works.
Thank you very much for all,
Enrico

Bjørn

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux