Re: [PATCH v1 8/9] ARM: tegra: Enable UDC on AC100

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07.07.2017 00:23, Marc Dietrich wrote:
> Am Donnerstag, 6. Juli 2017, 20:00:02 CEST schrieb Stephen Warren:
>> On 07/06/2017 10:57 AM, Dmitry Osipenko wrote:
>>> On 06.07.2017 19:38, Stephen Warren wrote:
>>>> On 07/05/2017 11:19 AM, Dmitry Osipenko wrote:
>>>>> Override the compatible string of the first USB controller to enable
>>>>> device mode.
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
>>>>> b/arch/arm/boot/dts/tegra20-paz00.dts
>>>>>
>>>>>        usb@c5000000 {
>>>>>
>>>>> +        compatible = "nvidia,tegra20-udc";
>>>>>
>>>>>            status = "okay";
>>>>>
>>>>> +        dr_mode = "otg";
>>>>>
>>>>>        };
>>>>
>>>> This port is the only external USB port on the AC100.
>>>
>>> Seems that's not true. http://elinux.org/Tegra/Boards/Toshiba_AC100 claims
>>> that there are host and micro USB ports.
>>
>> You're right; I was getting this board confused with the Springbank
>> variety of Seaboard, and when I looked at the mini USB port on the AC100
>> I thought it was something else.
> 
> Sorry, for the late reply, I'm on vacation.
>  

No worries, have a good time!;)

>> Given the physical connector on this USB port on the AC100, it's
>> probably fine to convert it to device-mode only since I don't expect
>> anyone has a USB OTG cable that has a mini size connector on the host end.
>>
>> It looks like this port is only enabled because the very first version
>> of tegra-paz00.dts didn't explicitly disable the port, and when
>> tegra20.dtsi was updated to disable all USB ports by default,
>> tegra-paz00.dtsi was updated to enable the port so that the DT change
>> didn't affect behaviour, which then left the port enabled explicitly
>> albeit without much reason.
> 
> I think someone used it in the past in host mode and it was working, but I 
> think everyone will be happy to have it operating as client only (as original 
> intended), especially because we already have an external (and also an 
> internal) usb port.
> 
>> So, once the dr_mode is fixed in this change, it's:
>> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
> 
> Tested-by: Marc Dietrich <marvin24@xxxxxx>
> 


-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux