Re: [PATCH v1 1/1] usb:xhci: update condition to select bus->sysdev from parent device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 6, 2017 at 2:11 PM, Thang Q. Nguyen <tqnguyen@xxxxxxx> wrote:
> For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA
> configuration"), sysdev points to devices known to the system firmware
> or hardware for DMA parameters.
> However, the parent of the system firmware/hardware device checking
> logic does not work in ACPI boot mode. This patch updates the formulation
> to check this case in both DT and ACPI.
>
> Signed-off-by: Tung Nguyen <tunguyen@xxxxxxx>
> Signed-off-by: Thang Q. Nguyen <tqnguyen@xxxxxxx>
> ---
>  drivers/usb/host/xhci-plat.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index c04144b..e3e342a 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -187,7 +187,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
>          * 3. xhci_plat is grandchild of a pci device (dwc3-pci)
>          */
>         sysdev = &pdev->dev;
> -       if (sysdev->parent && !sysdev->of_node && sysdev->parent->of_node)
> +       if (sysdev->parent && (sysdev->fwnode->type == FWNODE_PDATA) &&
> +               (is_of_node(sysdev->parent->fwnode) ||
> +                       is_acpi_device_node(sysdev->parent->fwnode)))
>                 sysdev = sysdev->parent;
>  #ifdef CONFIG_PCI
>         else if (sysdev->parent && sysdev->parent->parent &&
> --
> 1.7.1
>
Hi,
Do you have any comment on this patch?

Regards,
Thang Q. Nguyen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux