On 6/26/2017 9:55 PM, Jimmy Perchet wrote:
> Hello,
>
> According to DWC2 databook( 3.20a in my case), DTXFSTSn registers are
> indexed by endpoint number. This can be verified by comparing "fifo" and
> "regdump" in debugfs (as long as the configuration is not trivial).
> Therefore, in my humble opinion, the commit ad674a1524 ("usb: dwc2: gadget:
> use ep->fifo_index in context of FIFO registers") wrongly changes DTXFSTSn
> indexation.
>
> Best Regards,
> Jimmy Perchet
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=6z9Al9FrHR_ZqbbtSAsD16pvOL2S3XHxQnSzq8kusyI&m=WjxvxDeLW9-dLyu64KSY_IqugUrLZ-mEqzFFQ0rmgzE&s=s2ZNWjanbv8s-XwfeLZrK1Ks-rjO_CPu6EBjlUDtpVk&e=
>
Hi Jimmy,
Initially Vahram Aharonyan provided feedback to Robert Baldyga that this
commit is not correct
(http://marc.info/?l=linux-kernel&m=145458873711662&w=2).
Then Morgan Chang, based on Vahram's feedback, requested revert this
patch (http://marc.info/?l=linux-kernel&m=148394962002696&w=2).
And finally you pointed to the same wrong implementation
(http://marc.info/?l=linux-usb&m=149849973624892&w=2 )
Reverting patch will be submitted shortly.
Thanks,
Minas
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
