On 06/27/2017 02:58 AM, Yuyang Du wrote:
> The patch 03cd00d538a6: "usbip: vhci-hcd: Set the vhci structure up
> to work" introduced a bug which uses a vairable without initialization
> in error handling code. Fix it.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Yuyang Du <yuyang.du@xxxxxxxxx>
> ---
> drivers/usb/usbip/vhci_hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 64c3860..2c4b2fd 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1301,7 +1301,7 @@ static struct hc_driver vhci_hc_driver = {
>
> static int vhci_hcd_probe(struct platform_device *pdev)
> {
> - struct vhci *vhci;
> + struct vhci *vhci = *((void **)dev_get_platdata(&pdev->dev));
> struct usb_hcd *hcd_hs;
> struct usb_hcd *hcd_ss;
> int ret;
>
Looks good to me.
Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
