On Tue, Jun 13, 2017 at 11:57:14AM +0200, Johan Hovold wrote: > On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > > > On Tue, 6 Jun 2017 12:54:40 +0200 > > > Johan Hovold <johan@xxxxxxxxxx> wrote: > > > > > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and > > > > TIOCGICOUNT, and parity handling in set_termios which had suffered > > > > severe bit rot. > > > > > > I would be amazed if the IRDA code still works. It's not been tested > > > properly for years and it never followed the tty rules properly in the > > > first place - so this looks good, although moving IRDA into staging > > > and /dev/null would IMHO be far better. > > > > > > IRDA is dead, and IR remotes are handled via completely different code. > > > > I agree, and we should move it into staging and out of the tree, I'll > > send netdev some patches for that... > > Sounds good, but please consider applying this patch before moving to > staging as people have been modifying this dead code as part of > kernel-wide updates even though hasn't even compiled for quite some > time. That is, just that which you ended up doing. :) Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
