Hi,
Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> writes:
>>>>>>>>>>> this could be, I don't remember if I checked this or not :-)
>>>>>>>>>>>
>>>>>>>>>>> Really, the best way here, IMHO, would be to re-verify what's going on
>>>>>>>>>>> with macOS and revert my orignal patch since it's, rather clearly,
>>>>>>>>>>> wrong.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Sure. Are you going to make a revert patch or I am?
>>>>>>>>>
>>>>>>>>> Well, after we really know what's going on with macOS and have a better
>>>>>>>>> fix, then who makes the revert is less important as long as problems get
>>>>>>>>> sorted out :-) Either way is fine for me.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Do you have any update on this issue?
>>>>>>>>
>>>>>>>
>>>>>>> The patch ffb80fc672c3 ("usb: dwc3: gadget: skip Set/Clear Halt when
>>>>>>> invalid") still causes a regression for us. As there hasn't any update
>>>>>>> for the macOS issue, can I submit a revert patch for this?
>>>>>>
>>>>>> I just came back from vacations ;-) I'll get back to this. Reverting
>>>>>> that commit won't do any good as we'd be exchanging one regression for
>>>>>> another. We really need to understand what's going on.
>>>>>
>>>>> Hi Felipe,
>>>>>
>>>>> I think we worked around this same issue in the Synopsys vendor driver
>>>>> after a customer reported a problem with CLEAR_FEATURE(ENDPOINT_HALT).
>>>>> I no longer have access to either the databook or the codebase, so I
>>>>> can't be sure about what the workaround was, but if either John or Thinh
>>>>> can have a look at the Clear Stall code in the vendor driver they should
>>>>> be able to figure it out.
>>>
>>> Thanks a lot Paul :-) Good to see you still have a look here every once
>>> in a while :-)
>>>
>>> John, Thinh could either of you check what Paul mentions here?
>>>
>>> cheers
>>>
>>
>> Can you provide more detail on the issue you see on MAC OS? and how to
>> reproduce the issue?
>>
>
> This issue has been a regression for us for a few months now, do you
> have any update on this?
ordered a mac to test this again. It'll take a few days.
--
balbi
Attachment:
signature.asc
Description: PGP signature
