On 06/12/2017 05:41 AM, Heikki Krogerus wrote:
Hi Guenter,
On Mon, Jun 12, 2017 at 02:55:49PM +0300, Heikki Krogerus wrote:
+/* Command Status and Connector Change Indication (CCI) data structure */
+struct ucsi_cci {
+ u8:1; /* reserved */
+ u8 connector_change:7;
+ u8 data_length;
+ u16:9; /* reserved */
+ u16 not_supported:1;
+ u16 cancel_complete:1;
+ u16 reset_complete:1;
+ u16 busy:1;
+ u16 ack_complete:1;
+ u16 error:1;
+ u16 cmd_complete:1;
Wondering: Is this endianness clean ?
Same whereever you use bit fields. Or is the driver
only expected to work on little-endian systems ?
The idea was to support only support little endian with the driver
initially, but I'll try to improve the structures and by using
something like __BIG/LITTLE_ENDIAN_BITFIELD.
Just a clarification for this. I'll just add a proper dependency on
little-endian if that is OK. There were some concerns internally
regarding how to deal with big endian support in this driver, so I'll
keep it little endian for now. Let me know if that is not OK.
ok with me.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
