On Sun, Jun 11, 2017 at 11:32:43PM -0700, maglyx@xxxxxxxxx wrote: Thanks for resending. The eaten-tabs issue is gone, but there are still a few minor issues you should fix up. > This is v2, attempting to correct formatting problems with the patch. This type of meta information should not go in the commit message itself and should therefore be placed below the cut-off-line (a "---" line, below your Signed-off-by). > The qcserial driver fails to expose the .tiocmget and .tiocmset methods available from usb_wwan. These methods are required by ioctl commands dealing with the modem control signals DTR, RTS, etc. You need to wrap your commit-message lines at 72 cols or so. > With these methods not set ioctl calls intended to control the DTR state will fail. For example, pppd drops and raises DTR in preparation to dialing the modem, which handles the case of the modem already being connected by making it hang up and return to command mode. DTR control being unavailable will lead to a protracted failure to connect as the modem will be stuck in a state not responsive to command. > > I have tested that with this patch the described case is handled successfully. There is an analogous method for .ioctl available from usb_wwan (as used in option.c) but I conservatively omitted that for lack of familiarity. > > Signed-off-by: Magnus Lynch <maglyx@xxxxxxxxx> And finally, your mail From field should match your Signed-off-by and is currently lacking your name (this will be used for the author info in git). Care to fix this up in a v3? Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
