Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2017-06-11 at 09:46 +0200, Greg Kroah-Hartman wrote:
> On Fri, Jun 09, 2017 at 03:08:45PM +0300, Andy Shevchenko wrote:
> > Use __sysfs_match_string() helper instead of open coded variant.
> 
> __ functions shouldn't be exported, are you _sure_ this is a function
> you should be using?

Yes, I'm pretty sure, though I will use a complementary function in v2.

>   If so, shouldn't the api be fixed up instead?

Maybe, I dunno.

> And kbuild is having a field-day on your patches, reporting them all
> as
> broken :(
> 

Yeah, sorry for that. I just checked v2 and it compiles fine.
Will send ASAP.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux