Re: [PATCH] em28xx TerraTec Cinergy Hybrid T USB XS with demodulator MT352 is not detect by em28xx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 11, 2017 at 09:30:03AM +0200, juvann@xxxxxxxxxxx wrote:
> I tried to sent this patch many times in past to linux-media, but I was ignored, I hope someone on linux-usb can submit this patch for resolve an issue on usb device.
> 
> TerraTec Cinergy Hybrid T USB XS with demodulator MT352 stop working with kernel 3.xx and newer.
> 
> --- /usr/src/linux-3.14.3/drivers/media/usb/em28xx/em28xx-cards.c.orig   2014-05-06 16:59:58.000000000 +0200
> +++ /usr/src/linux-3.14.3/drivers/media/usb/em28xx/em28xx-cards.c   2014-05-07 15:18:31.719524453 +0200
> @@ -2233,7 +2233,7 @@
>         { USB_DEVICE(0x0ccd, 0x005e),
>                         .driver_info = EM2882_BOARD_TERRATEC_HYBRID_XS },
>         { USB_DEVICE(0x0ccd, 0x0042),
> -                       .driver_info = EM2882_BOARD_TERRATEC_HYBRID_XS },
> +                       .driver_info = EM2880_BOARD_TERRATEC_HYBRID_XS },
>         { USB_DEVICE(0x0ccd, 0x0043),
>                         .driver_info = EM2870_BOARD_TERRATEC_XS },
>         { USB_DEVICE(0x0ccd, 0x008e),   /* Cinergy HTC USB XS Rev. 1 */
> 
> This patch is working also on kernel 4.xx I have tested kernel on 4.3 and 4.9

Please read Documentation/SubmittingPatches for how to properly submit a
kernel patch.  There's multiple things "wrong" here, including, but not
limited to:
	- no signed off by
	- sent to the wrong people (use scripts/get_maintainer.pl)
	- patch is corrupted by tabs being turned into spaces
	- changelog text needs to be line-wrapped properly
	- wrong depth of the patch
	- needs to be made against the latest kernel tree (we can't go
	  back in time...)

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux