Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.12-rc4 next-20170609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/usb-misc-usbsevseg-Use-__sysfs_match_string-helper/20170610-055240
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-b0-06101036 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/usb/misc/usbsevseg.c: In function 'set_attr_textmode':
>> drivers/usb/misc/usbsevseg.c:307: warning: passing argument 1 of '__sysfs_match_string' from incompatible pointer type
   include/linux/string.h:146: note: expected 'const char * const*' but argument is of type 'char **'

vim +/__sysfs_match_string +307 drivers/usb/misc/usbsevseg.c

   291				strcat(buf, " ");
   292			}
   293		}
   294		strcat(buf, "\n");
   295	
   296	
   297		return strlen(buf);
   298	}
   299	
   300	static ssize_t set_attr_textmode(struct device *dev,
   301		struct device_attribute *attr, const char *buf, size_t count)
   302	{
   303		struct usb_interface *intf = to_usb_interface(dev);
   304		struct usb_sevsegdev *mydev = usb_get_intfdata(intf);
   305		int i;
   306	
 > 307		i = __sysfs_match_string(display_textmodes, -1, buf);
   308		if (i < 0)
   309			return i;
   310	
   311		mydev->textmode = i;
   312		update_display_visual(mydev, GFP_KERNEL);
   313		return count;
   314	}
   315	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux