On 06/09/2017 04:03 AM, Heikki Krogerus wrote:
Hi Guenter,
On Mon, Jun 05, 2017 at 05:30:22PM +0300, Heikki Krogerus wrote:
Hi,
This moves the current ucsi driver from drivers/usb/misc/ucsi.c to the
new USB Type-C class (drivers/usb/typec/). That allows us to finally do
role swapping.
The driver is now split into core library part, and ACPI driver. That
should make it easy to add support for other interface methods (first
most likely being I2C) later if needed.
Changes since v1:
- Added separate flag from pending ACK. Some new platforms generate "command
complete" event on top of the normal "ACK complete" event with ACK commands.
In such cases the driver has to be able to basically ignore the command
completion in case of ACK and only finish acknowledge routine when the actual
ACK complete event is received. Otherwise a new command may be queued to the
PPM before the previous has fully completed.
- Added an explanation why we are handling the PPM initialization in a work as
suggested by Guenter.
- Fixed ucsi_reset_ppm() by removing possibility of returning -ETIMEDOUT in case
of success right before the time expires. Suggested by Guenter.
- Replaced useless "goto err;" with "break;" in ucsi_run_command() as suggested
by Guenter.
- Removed traceback in case of failure from ucsi_run_command() which is not
necessary as suggested by Guenter.
- Highlighting the fact that the timeouts are in milliseconds by using _MS
ending with the definition (UCSI_TIMEOUT_MS and UCSI_SWAP_TIMEOUT_MS) as
suggested by Guenter.
- Including also <linux/bitops.h> in ucsi.h as suggested by Guenter.
- In ucsi_acpi.c, explicitly pointing out in the comment that we can not use
devm_ioremap_resource() as suggested by Guenter.
Heikki Krogerus (2):
usb: typec: Add support for UCSI interface
usb: typec: ucsi: Add ACPI driver
Gentle ping.
Are these OK now?
I am far behind, sorry :-(. I'll try to get to it today or during the weekend.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
