Re: [PATCH v2] usb: xhci: Issue stop EP command only when the EP state is running

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2 Jun 2017, Shyam Sundar S K wrote:

> on AMD platforms with SNPS 3.1 USB controller if stop endpoint command is
> issued the controller does not respond, when the EP is not in running
> state. HW completes the command execution and reports
> "Context State Error" completion code. This is as per the spec. However
> HW on receiving the second command additionally marks EP to Flow control
> state in HW which is RTL bug. The above bug causes the HW not to respond
> to any further doorbells that are rung by the driver. This causes the EP
> to not functional anymore and causes gross functional failures.
> 
> As a workaround, not to hit this problem, its better we check the EP state
> and issue the stop EP command only when the EP is in running state.

Isn't there an unavoidable race?  Suppose you check the EP state and
the controller says the endpoint is running.  But then a STALL packet
is received and the controller stops the endpoint before you can issue
the Stop-EP command.  How would you handle that?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux