RE: [PATCH v4] usb:host:xhci:USB 3.1 speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the hand:)

Thanks,
YD

> -----Original Message-----
> From: Mathias Nyman [mailto:mathias.nyman@xxxxxxxxxxxxxxx]
> Sent: Friday, May 26, 2017 6:50 PM
> To: YD; gregkh@xxxxxxxxxxxxxxxxxxx; mathias.nyman@xxxxxxxxx; linux-
> usb@xxxxxxxxxxxxxxx
> Cc: yd_tseng@xxxxxxxxxxxxxx
> Subject: Re: [PATCH v4] usb:host:xhci:USB 3.1 speed
> 
> On 26.05.2017 13:27, YD wrote:
> > From: YD Tseng <yd_tseng@xxxxxxxxxxxxxx>
> >
> > One of the xHCI host controllers supports both USB 3.1/3.0 extended
> > speed protocol lists. The content of the lists is shown as below.
> > In xhci-mem.c, the USB 3.1 speed is parsed first, the min_rev of
> > usb3_rhub is set as 0x10.  And then USB 3.0 is parsed.  However, the
> > min_rev of usb3_rhub will be changed to 0x00. If USB 3.1 device is
> > connected behind this host controller, the speed of USB 3.1 device
> > just reports 5G speed using lsusb.
> >
> >       00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
> >    00 01 08 00 00 00 00 00 40 00 00 00 00 00 00 00 00
> >    10 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >    20 02 08 10 03 55 53 42 20 01 02 00 00 00 00 00 00     //USB 3.1
> >    30 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >    40 02 08 00 03 55 53 42 20 03 06 00 00 00 00 00 00     //USB 3.0
> >    50 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >    60 02 08 00 02 55 53 42 20 09 0E 19 00 00 00 00 00     //USB 2.0
> >    70 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >
> > This patch works around for parsing extended speed protocol lists. If
> > the xHCI controller supports USB 3.1 and 3.0 extended speed protocol,
> > it could show as one 3.1 roothub.
> >
> > Signed-off-by: YD Tseng <yd_tseng@xxxxxxxxxxxxxx>
> > ---
> 
> There is one small complaint from checkpatch about the commit message
itself:
> 
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars
> per line)
> #11:
> this host controller, the speed of USB 3.1 device just reports 5G speed
using
> 
> total: 0 errors, 1 warnings, 23 lines checked
> 
> 
> I'll fix that myself, no need to resend
> 
> Applied,
> Thanks
> -Mathias


==================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it 
is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete 
the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized 
disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views 
or opinions expressed are solely those of the author and do not represent those of ASMedia Technology Inc. Thank you for your cooperation.
==================================================================================================================

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux