On Fri, May 26, 2017 at 05:35:24PM +0800, Jiahau Chang wrote:
> There is some limitation for AMD Promontory xHCI host to disable USB port
> function. It will enable USB wake-up function then cause USB disable port
> feature to fail. Workaround this issue on Promontory xHCI host is clear
> PORT_WAKE_BITS.
>
> Signed-off-by: Jiahau Chang <Lars_chang@xxxxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci-hub.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
What changed from v1? Always put that information below the --- line,
as Documentation/SubmittingPatches describes.
And why the leading space on the changelog?
thanks,
greg k-h
>
> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
> index 51e408b..fa5ef22 100644
> --- a/drivers/usb/host/xhci-hub.c
> +++ b/drivers/usb/host/xhci-hub.c
> @@ -1224,7 +1224,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> "actual port %d status = 0x%x\n",
> wIndex, temp);
> }
> - else {
> + else {
This needs to go up one line.
> xhci_set_remote_wake_mask(xhci, port_array,
> wIndex, wake_mask);
> temp = readl(port_array[wIndex]);
> @@ -1469,7 +1469,6 @@ int xhci_bus_suspend(struct usb_hcd *hcd)
> t2 |= PORT_WKOC_E | PORT_WKCONN_E;
> t2 &= ~PORT_WKDISC_E;
> }
> -
Your patch does nothing here, are you sure you didn't just make this
against your last patch?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
