Update V3 patch
>> + xhci->usb3_rhub.min_rev = 0;
>> + xhci->usb2_rhub.min_rev = 0;
>
> Why set these? Are they not already cleared out at initialization time?
They are already cleared out at initialization, removing these 2 lines.
Thanks,
YD
On Tue, May 23, 2017 at 8:09 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, May 23, 2017 at 06:50:49PM +0800, YD wrote:
>> From: YD Tseng <Yd_Tseng@xxxxxxxxxxxxxx>
>>
>> Hi Greg and Mathias,
>
> Why is this here? :)
>
> Hint, send what you want in the changelog, in the changelog area,
> anything else you want to say, put below the --- line, like
> Documentation/SubmittingPatches says to do.
>
>>
>> This patch works around for parsing extended speed protocol lists.
>
> Trailing space :(
>
>> If the xHCI controller supports USB 3.1 and 3.0 extended speed protocol,
>> it could show as one 3.1 roothub.
>
> I don't understand, what does it do today?
>
>
>>
>> Changes since v1:
>> - change diff path
>
> The changes go below ---
>
>
>>
>> Signed-off-by: YD Tseng <Yd_Tseng@xxxxxxxxxxxxxx>
>>
>> ---
>>
>> diff -up linux/drivers/usb/host/xhci-mem.c{.orig,} > /tmp/patch
>
> Where did this line come from? git?
>
>> --- linux/drivers/usb/host/xhci-mem.c.orig 2017-04-08 15:35:38.000000000 +0800
>> +++ linux/drivers/usb/host/xhci-mem.c 2017-05-22 11:56:21.362907677 +0800
>> @@ -2111,11 +2111,12 @@ static void xhci_add_in_port(struct xhci
>> {
>> u32 temp, port_offset, port_count;
>> int i;
>> - u8 major_revision;
>> + u8 major_revision, minor_revision;
>> struct xhci_hub *rhub;
>>
>> temp = readl(addr);
>
> All of your tabs got changed into spaces, making this patch impossible
> to apply :(
>
>> major_revision = XHCI_EXT_PORT_MAJOR(temp);
>> + minor_revision = XHCI_EXT_PORT_MINOR(temp);
>>
>> if (major_revision == 0x03) {
>> rhub = &xhci->usb3_rhub;
>> @@ -2129,7 +2130,9 @@ static void xhci_add_in_port(struct xhci
>> return;
>> }
>> rhub->maj_rev = XHCI_EXT_PORT_MAJOR(temp);
>> - rhub->min_rev = XHCI_EXT_PORT_MINOR(temp);
>> +
>> + if (rhub->min_rev < minor_revision)
>> + rhub->min_rev = minor_revision;
>
> Why change the revision from what it was?
>
>>
>> /* Port offset and count in the third dword, see section 7.2 */
>> temp = readl(addr + 2);
>> @@ -2280,6 +2283,8 @@ static int xhci_setup_port_arrays(struct
>>
>> offset = cap_start;
>>
>> + xhci->usb3_rhub.min_rev = 0;
>> + xhci->usb2_rhub.min_rev = 0;
>
> Why set these? Are they not already cleared out at initialization time?
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
