Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 24, 2017 at 05:08:10PM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 24, 2017 at 03:54:23PM +0300, Heikki Krogerus wrote:
> > Driver for USB Type-C PHY on Intel WhiskeyCove PMIC that
> > works with Type-C Port Controller Manager to provide USB
> > Power Delivery and USB Type-C functionalities
> > 
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/staging/typec/Kconfig       |  11 +
> >  drivers/staging/typec/Makefile      |   1 +
> >  drivers/staging/typec/typec_wcove.c | 684 ++++++++++++++++++++++++++++++++++++
> >  drivers/usb/typec/Makefile          |   1 -
> >  drivers/usb/typec/typec_wcove.c     | 377 --------------------
> >  5 files changed, 696 insertions(+), 378 deletions(-)
> >  create mode 100644 drivers/staging/typec/typec_wcove.c
> >  delete mode 100644 drivers/usb/typec/typec_wcove.c
> > 
> > Hi,
> > 
> > I would like to register also this driver with tcpm, but since tcpm is
> > in staging, can we move the driver to staging like in this patch?
> 
> How about spending the time to get the code out of staging instead?  I
> don't like adding new features to staging drivers, instead, I want to
> see people working to fix what we have before adding new stuff...
> 
Either case I think it should possibly be a different driver: One without
PD support, the other one with PD support.

But I agree, we have to get this out of staging. It is good though that
we got it in - there is more interest in it than I thought.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux