RE: [PATCH] usb:host:xhci:USB 3.1 Speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

 One of our xHCI host controlers has 3 extended speed protocol lists.  The
content of extended speed protocol lists is shown as below.
 In xhci-mem.c, the USB 3.1 speed is parsed first, the min_rev of usb3_rhub
is set as 0x10.  And then USB 3.0 is parsed.  However, the min_rev of
usb3_rhub will be changed to 0x00.
 If USB 3.1 device is connected behind this host controller, the speed of
USB 3.1 device just reports 5G speed using lsusb.

      00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
 00 01 08 00 00 00 00 00 40 00 00 00 00 00 00 00 00
 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 20 02 08 10 03 55 53 42 20 01 02 00 00 00 00 00 00     //USB 3.1
 30 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 40 02 08 00 03 55 53 42 20 03 06 00 00 00 00 00 00     //USB 3.0
 50 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 60 02 08 00 02 55 53 42 20 09 0E 19 00 00 00 00 00     //USB 2.0
 70 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

-----Original Message-----
From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] 
Sent: Tuesday, May 23, 2017 5:18 PM
To: YD
Cc: mathias.nyman@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
yd_tseng@xxxxxxxxxxxxxx
Subject: Re: [PATCH] usb:host:xhci:USB 3.1 Speed

On Tue, May 23, 2017 at 03:00:47PM +0800, YD wrote:
> From: YD Tseng <Yd_Tseng@xxxxxxxxxxxxxx>
> 
> Hi Mathias,
> 
> This patch works around for parsing extended speed protocol lists. 
> If the xHCI controller supports USB 3.1 and 3.0 extended speed 
> protocol, it could show as one 3.1 roothub.
> 
> Signed-off-by: YD Tseng <Yd_Tseng@xxxxxxxxxxxxxx>
> 
> ---
> 
> A file is modified.
> drivers/usb/host/xhci-mem.c		Modified file

What does this mean?

> 
> diff -up xhci-mem{.orig,} > /tmp/patch
> --- xhci-mem.c.orig     2017-04-08 15:35:38.000000000 +0800
> +++ xhci-mem.c  2017-05-22 11:56:21.362907677 +0800

You need to make the patch "deeper", please see
Documentation/SubmittingPatches for how to create it properly.

thanks,

greg k-h

==================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it 
is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete 
the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized 
disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views 
or opinions expressed are solely those of the author and do not represent those of ASMedia Technology Inc. Thank you for your cooperation.
==================================================================================================================

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux