On Tue, May 23, 2017 at 10:44:05AM +1000, Benjamin Herrenschmidt wrote: > The Aspeed 2400/2500 families have a variant of UHCI which requires > some quirks to the driver to work: > > - The register offsets are different. We add a remapping helper. > > - All accesses have to be done via 32-bit loads and stores. We > force all accessors to use readl/writel. This is of no consequence > for reads as we never read "in the middle" of a register. For writes > it also works fine as the registers only actually implement the bits > we try to write (16-bit for the registers accessed with writew and > 8-bit for the register accessed with writeb), so always using a > 32-bit write will have no negative effect. We never do partial writes. > > - The resume detect interrupt is broken > > - The number of ports is (optionally) provided via the device-tree > > Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Looks much nicer to me, thanks for the changes. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
