On Mon, 2017-05-22 at 11:29 +0200, Greg KH wrote: > On Mon, May 22, 2017 at 06:43:25PM +1000, Benjamin Herrenschmidt wrote: > > The Aspeed 2400/2500 families have a variant of UHCI which requires > > some quirks to the driver to work: > > A UHCI driver? New hardware? That's crazy, what decade is this? :) Haha, not *that* new HW, but yeah, those Aspeed SoC are made of all sort of funny bits of IP, sometimes rather gothic :-) > > --- a/drivers/usb/host/uhci-hcd.c > > +++ b/drivers/usb/host/uhci-hcd.c > > @@ -269,6 +269,10 @@ static int resume_detect_interrupts_are_broken(struct uhci_hcd *uhci) > > * we can't depend on resume-detect interrupts. */ > > if (ignore_oc) > > return 1; > > +#ifdef CONFIG_USB_UHCI_ASPEED > > + if (uhci->is_aspeed) > > + return 1; > > +#endif > > Ick, you know better, don't put #ifdefs everywhere, just always check > for this, no need to clutter up the code please. In looking over this > code, I don't think you need any #ifdef at all. Well, I had made the is_aspeed field conditional in the structure but you are right, it's pointless, it's a 1 bit bitfield, it's not like it's going to bloat anything. I'll take out those ifdef's. In fact, I'm thinking I should be able to remove most of the ones in the .h file as well with smarter use of inlines. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
